[Webkit-unassigned] [Bug 138464] New: [EFL] Make easier to enable/disable API tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138464

            Bug ID: 138464
           Summary: [EFL] Make easier to enable/disable API tests
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ossy at webkit.org
            Blocks: 137818

Idea from bug137818:
> > - be able to disable API tests easily (87 relinking --> 9 relinking)
> It is already possible with build-webkit --cmakeargs="-DENABLE_API_TESTS=OFF"
> performance win: ~ 1 minute

Now the incremental build takes 21 seconds with ld.gold if I touch only one
random file from WebCore. It is still too much during active development. :)

I know I can disable API tests with --cmakeargs="-DENABLE_API_TESTS=OFF"
command line argument of build-webkit. It reduces build time to ... seconds.

But it isn't as comfortable as it can be. This command line option has a big issue, 
it is passed to GCC as command line argument. If you change your mind, and you would 
like to build API tests again or vice-versa (or simple forget to pass this option),
all sources will be rebuilt. :-/ 

I checked the code base and it seems only GTK needs this define to be passed to compiler for 2 files only:
- Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp
- Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
  ( which includes InputMethodFilter.h )

My goals are:
- simpler option than --cmakeargs="-DENABLE_API_TESTS=OFF" , or environment variable
- avoid rebuilding everything if ENABLE_API_TESTS configuration changes

How to do it: still thinking :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141106/3c66e171/attachment-0002.html>