[Webkit-unassigned] [Bug 138405] splitText API does not match DOM specification

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138405

--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 241083
  --> https://bugs.webkit.org/attachment.cgi?id=241083
Patch-Updated

View in context: https://bugs.webkit.org/attachment.cgi?id=241083&action=review

The web-exposed behavior change seems fine as it matches the specification and the behavior other major browsers but please take into consideration my comments.

> Source/WebCore/ChangeLog:7
> +

This matches the behavior of both Firefox 33 and Chrome 38. Please state so in your Changelog as this is more important than matching the specification.

Also, please indicate in the Changelog which web-exposed changes you are making:
1. Make the offset argument mandatory (and thus throw if it is omitted)
2. No longer throw if the offset argument is negative (and wraps to a valid index)

> LayoutTests/fast/dom/Text/splitText.html:14
> +shouldThrow('text.splitText()');

Please specify the second argument to shouldThrow (exception name)

> LayoutTests/fast/dom/Text/splitText.html:15
> +shouldThrow('text.splitText(999)');

ditto.

> LayoutTests/fast/dom/Text/splitText.html:16
> +shouldThrow('text.splitText(-1)');

ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141106/41130fd5/attachment-0002.html>