[Webkit-unassigned] [Bug 138364] Web Inspector: decouple child element folderization logic from FrameTreeElement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 5 17:15:19 PST 2014


--- Comment #5 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 240983
  --> https://bugs.webkit.org/attachment.cgi?id=240983

View in context: https://bugs.webkit.org/attachment.cgi?id=240983&action=review

>> Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js:32
>> +    this._folderSettingsKey = "";
> I worry that _folderSettingsKey will be used before the client sets it to something meaningful. Any reason folderSettingsKey can't be set in the constructor?

Making folderSettingsKey a constructor argument would be awkward due to the inheritance chain: FolderizedTreeElement <- SourceCodeTreeElement <- ResourceTreeElement <- FrameTreeElement. Since it isn't used until child items are added, I don't think there is a risk of it being used before it is initialized.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141106/10693667/attachment-0002.html>

More information about the webkit-unassigned mailing list