[Webkit-unassigned] [Bug 135923] [CSS Shapes] the sandbag JS utility code isn't producing the correct expected result in the shape-image gradient tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135923

Bem Jones-Bey <bjonesbe at adobe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bjonesbe at adobe.com

--- Comment #1 from Bem Jones-Bey <bjonesbe at adobe.com> ---
I don't think this is a fault of the JS utility code. I replaced the JS code in the expected file with a circle() shape outside (in the 001 test), and the JS code and the circle() both give the same shape that is different from the shape created by the gradient. Examining the shape drawn by the inspector for both the gradient shape case and the circle shape case, it looks to me like the gradient creates a shape, that while circular, has a much rougher contour, so there are places where it is farther our and places where it is closer in than the clean circle.

It may make the most sense to use math like in the JS utility to figure out where the text should be positioned in the ideal case, and then have a delta that it can vary and just check that the text is positioned within that delta. (Making it a testharness test instead of a ref test.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141104/7efb59e8/attachment-0002.html>