[Webkit-unassigned] [Bug 138311] [GTK] Add context menu API to Web Process Extensions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138311

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 240864 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240864&action=review
> 
> I like the idea and the API, the code looks correct to me as well.

This is needed by Yelp, I'll try to use this in yelp asap to make sure the API is good.

> > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:257
> > +    } else {
> > +        WKRetain(wkDefaultMenu);
> > +        *wkNewMenu = wkDefaultMenu;
> > +    }
> 
> How about making this an early return?

Sure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141104/05040674/attachment-0002.html>