[Webkit-unassigned] [Bug 138333] Implement action menus for editable text with spelling suggestions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138333

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240881|review?                     |review+
              Flags|                            |

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 240881
  --> https://bugs.webkit.org/attachment.cgi?id=240881
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240881&action=review

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:570
> +                Vector<String> guesses;

Please push this down into _defaultMenuItemsForEditableTextWithSuggestions.

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:575
> +                    for (unsigned i = 0; i < guesses.size(); i++) {

Modern for loop here, please?

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:1185
> +    HitTestResult result = m_page->mainFrame().eventHandler().hitTestResultAtPoint(m_page->mainFrame().view()->windowToContents(point), HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowChildFrameContent | HitTestRequest::IgnoreClipping);

We already have a mainFrame local reference, why are we getting it from m_page repeatedly here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141104/ac076408/attachment-0002.html>