[Webkit-unassigned] [Bug 138332] New: libwebkit2gtk fails to link without opengl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138332

            Bug ID: 138332
           Summary: libwebkit2gtk fails to link without opengl
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: benedikt.morbach at googlemail.com

If built without OpenGL, libwebkit2gtk fails to link because it is missing '-lX11' and friends.

CMakeFiles/WebKit2.dir/PluginProcess/unix/PluginProcessMainUnix.cpp.o: In function `WebKit::webkitXError(_XDisplay*, XErrorEvent*)':
PluginProcessMainUnix.cpp:(.text+0x11): undefined reference to `XGetErrorText'
CMakeFiles/WebKit2.dir/PluginProcess/unix/PluginProcessMainUnix.cpp.o: In function `WebKit::PluginProcessMain::parseCommandLine(int, char**)':
PluginProcessMainUnix.cpp:(.text._ZN6WebKit17PluginProcessMain16parseCommandLineEiPPc[_ZN6WebKit17PluginProcessMain16parseCommandLineEiPPc]+0xe2): undefined reference to `XSetErrorHandler'
<snip>
...and a lot more errors along those lines

As far as I can tell this is because OptionsGTK.cmake doesn't explicitly call
find_package(X11), but relies on FindOpenGL doing so implicitly.
($X11_*_LIB are referenced in WebCore/PlatformGTK.cmake)

However, OpenGL is an optional dependency and as such can be disabled using
cmakes CMAKE_DISABLE_FIND_PACKAGE_FOO. (see [1]).

I think the correct fix would be to explicitly call find_package(X11), probably inside if (ENABLE_X11_TARGET)

[1] http://www.cmake.org/cmake/help/v3.0/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141104/0145092c/attachment-0002.html>