[Webkit-unassigned] [Bug 138325] Web Inspector: Fix RWIProtocol 64-to-32 bit conversion warnings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138325

--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
(In reply to comment #6)
> Comment on attachment 240874 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240874&action=review
> 
> > Source/JavaScriptCore/ChangeLog:14
> > +        Use int instead of NSInteger for APIs that eventually map to
> > +        InspectorObject's setInteger, which takes an int.
> 
> Feels like a step backwards. Can we fix InspectorObject's setInteger instead?

If we changed setInteger to support NSInteger it likely be size_t.

However, there is a potential real issue here. These "int" values get JSON serialized, and JavaScript Integers can not be a full 64bit integer:

> JavaScript represents numbers using IEEE-754 double-precision (64 bit) format.
> As I understand it this gives you 53 bits precision

The compromise that the JSC JSValue API went with was using an explicit int32_t for creating a JSValue with an integer value. We could move our Internal APIs to that type, but I think just using int for now is fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141103/7cc0f200/attachment-0002.html>