[Webkit-unassigned] [Bug 138315] [JSC] Erratum (835769) in Cortex-A53

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138315

Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240860|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #3 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 240860
  --> https://bugs.webkit.org/attachment.cgi?id=240860
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=240860&action=review

LGTM with the one suggestion.

> Source/JavaScriptCore/assembler/ARM64Assembler.h:1571
> +#if CPU(ARM64_CORTEXA53)

You could remove this #if and instead have an #if inside the nopCortexA53Fix835769() method. That would beautify the code quite a bit without any change in perf or behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141103/2953f4f6/attachment-0002.html>