[Webkit-unassigned] [Bug 138284] Implement action menus for editable text
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Nov 1 17:10:35 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=138284
Tim Horton <thorton at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #240797|review? |review+
Flags| |
--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 240797
--> https://bugs.webkit.org/attachment.cgi?id=240797
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=240797&action=review
> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:339
> +-(void)_paste:(id)sender
"copyText", but "paste"? copy can copy things that aren't text; can we go with _copy and _paste or _performCopy and _performPaste or something?
> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:496
> + return hitTestResult;
.release() here, I think
> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:503
> + _type = kWKActionMenuNone;
unfortunate that the 'none' case is duplicated now.
> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:518
> + if (DDActionContext *actionContext = _hitTestResult.actionContext.get()) {
We should shuffle this out into a "defaultMenuItemsForDataDetectedItem" or something, so that these all look the same.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141102/dac4afe0/attachment-0002.html>
More information about the webkit-unassigned
mailing list