[Webkit-unassigned] [Bug 133412] Srcset refactoring to match spec changes
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 30 20:56:04 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=133412
Darin Adler <darin at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #232305|review? |review-
Flag| |
--- Comment #3 from Darin Adler <darin at apple.com> 2014-05-30 20:56:24 PST ---
(From update of attachment 232305)
View in context: https://bugs.webkit.org/attachment.cgi?id=232305&action=review
Patch is not compiling on Mac or Windows.
I suggest breaking this patch up into two pieces. One patch can rearrange the code and refactor so it’s in a new location. The second patch should have the substantive change. It’s hard to successfully review a patch that both moves and changes code so it’s best to do the move and the change in two separate steps.
> Source/JavaScriptCore/ChangeLog:6
> + Added a PICTURE_ELEMENT compile flag.
Tabs not allowed in WebKit source files, including change log.
> Source/WebCore/ChangeLog:3
> + Srcset refactoring to match spec changes
Changing behavior is not “refactoring”, so this title is wrong.
> Source/WebCore/ChangeLog:8
> + No new tests (OOPS!).
This needs to be replaced by a line that doesn’t say “OOPS”.
> LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html:7
> -<script src="../../resources/js-test.js"></script>
> +<script src="../../resources/js-test-pre.js"></script>
Why this change? It broke the test: we no longer get successfullyParsed. If we use pre.js then we also need to use post.js.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list