[Webkit-unassigned] [Bug 132527] AX: [ATK] [PATCH] add text-caret-moved signal to accessibilityController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132527





--- Comment #30 from Jarek Czekalski <jarekczek at poczta.onet.pl>  2014-05-30 12:47:39 PST ---
(In reply to comment #27)
> Damm... I just found out that I missed two things while reviewing this patch, that caused two tests to get broken:
> 
>   accessibility/notification-listeners.html [ Failure ]
>   accessibility/textarea-selected-text-range.html [ Failure ]
> [...]
> The second test is broken because of this:
> [...]
> +    if (length)
> +        return atk_text_set_caret_offset(ATK_TEXT(m_element.get()), 
[...]
> It should be "if (!length)" not, "if (length)". I'll propose a quick patch now...

I did that mistake during style fix. length == 0 would be more readable here (as in 2.00), but such expressions are banned. It's funny that it didn't affect my tests at all.

My fault, I'm sorry. But please note that I was looking for a way to perform all tests: https://bugs.webkit.org/show_bug.cgi?id=131373#c3

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.