[Webkit-unassigned] [Bug 133401] WebCore build fix for webreplay

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 30 11:56:00 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=133401


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #232294|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #6 from Darin Adler <darin at apple.com>  2014-05-30 11:56:22 PST ---
(From update of attachment 232294)
View in context: https://bugs.webkit.org/attachment.cgi?id=232294&action=review

> Source/WebCore/replay/MemoizedDOMResult.cpp:60
> +    default:
> +        RELEASE_ASSERT_NOT_REACHED();
> +        return nullptr;

This should be put outside the switch statement instead of in a default case. Adding a default case turns off the warning we get when we forget to handle a case, and we’d like to leave that on.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list