[Webkit-unassigned] [Bug 132527] AX: [ATK] [PATCH] add text-caret-moved signal to accessibilityController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132527





--- Comment #27 from Mario Sanchez Prada <mario at webkit.org>  2014-05-30 08:02:02 PST ---
(In reply to comment #26)
> (In reply to comment #25)
> > (In reply to comment #24)
> > >It would be different if we had a bugfix that we wanted to merge in 2.4.
> > 
> > Mario, could we make it clear: do we want the fixes for bug #130941 and bug #132349 (not yet ready) to be merged in 2.4?
> 
> I'd say "yes", but we need to make sure that the proposed list of patches apply cleanly on top of that branch.

Damm... I just found out that I missed two things while reviewing this patch, that caused two tests to get broken:

  accessibility/notification-listeners.html [ Failure ]
  accessibility/textarea-selected-text-range.html [ Failure ]

The first test is broken because of this:

+    const char* signalNames[] = {
+        "ATK:AtkObject:state-change",
+        "ATK:AtkObject:state-change",  // DUPLICATED
+        "ATK:AtkObject:focus-event",
+        "ATK:AtkObject:active-descendant-changed",
+        "ATK:AtkObject:children-changed",
+        "ATK:AtkObject:property-change",
+        "ATK:AtkObject:visible-data-changed",
+        "ATK:AtkDocument:load-complete",
+        "ATK:AtkText:text-caret-moved",
+        0
+    };

The second test is broken because of this:

-void AccessibilityUIElement::setSelectedTextRange(unsigned location, unsigned length)
+bool AccessibilityUIElement::setSelectedTextRange(unsigned location, unsigned length)
 {
     if (!ATK_IS_TEXT(m_element.get()))
-        return;
+        return false;
+
+    if (length)
+        return atk_text_set_caret_offset(ATK_TEXT(m_element.get()), location);

-    atk_text_set_selection(ATK_TEXT(m_element.get()), 0, location, location + length);
+    return atk_text_set_selection(ATK_TEXT(m_element.get()), 0, location, location + length);
 }


It should be "if (!length)" not, "if (length)". I'll propose a quick patch now...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.