[Webkit-unassigned] [Bug 133028] Build break of 2.4.1 under mingw32/msys

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133028





--- Comment #24 from Alberto Garcia <berto at igalia.com>  2014-05-30 07:48:25 PST ---
(From update of attachment 231631)
View in context: https://bugs.webkit.org/attachment.cgi?id=231631&action=review

> webkitgtk-2.4.1/Source/WTF/wtf/MathExtras.h:75
> +#ifndef M_SQRT2
> +const double sqrtOfTwoDouble = 1.41421356237309504880;
> +#else
> +const double sqrtOfTwoDouble = M_SQRT2;
> +#endif
> +

[...]

> webkitgtk-2.4.1/Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp:75
> -            m_minPreferredLogicalWidth = minPreferredLogicalWidth() * float(M_SQRT2);
> -            m_maxPreferredLogicalWidth = maxPreferredLogicalWidth() * float(M_SQRT2);
> +            m_minPreferredLogicalWidth = minPreferredLogicalWidth() * float(sqrtOfTwoDouble);
> +            m_maxPreferredLogicalWidth = maxPreferredLogicalWidth() * float(sqrtOfTwoDouble);

This one looks fine, maybe we can define sqrtOfTwoFloat in MathExtras.h like we do with M_PI and friends and use it here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.