[Webkit-unassigned] [Bug 133400] Buildfix on Linux, uint64_t and unsigned long conflict

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133400





--- Comment #2 from Brian Burg <burg at cs.washington.edu>  2014-05-30 07:25:27 PST ---
(From update of attachment 232284)
View in context: https://bugs.webkit.org/attachment.cgi?id=232284&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Buildfix on Linux, uint64_t and unsigned long conflict

Generally, I name replay-related bugs like 'Web Replay: [bug title]'
so that they are easier to find later. But that's just my preference.

> Source/JavaScriptCore/ChangeLog:8
> +        The uint64_t and unsigned long do the same typedef

I think the issue is that they are distinct types on Darwin [1], whereas on Linux and maybe other platforms they are typedefed to the same type. So, this guard may end up being #if !OS(LINUX) depending on whatever windows does. I think it's fine for now.

[1] https://developer.apple.com/library/mac/documentation/Darwin/Reference/Manpages/man5/types.5.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.