[Webkit-unassigned] [Bug 132527] AX: [ATK] [PATCH] add text-caret-moved signal to accessibilityController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132527


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #232251|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #18 from Mario Sanchez Prada <mario at webkit.org>  2014-05-30 02:14:14 PST ---
(From update of attachment 232251)
View in context: https://bugs.webkit.org/attachment.cgi?id=232251&action=review

Thanks for the new patch, it's almost there. Only a minor suggestion (in the ChangeLog, sorry!) and I think we are ready to give this a try.

(In reply to comment #16)
> (From update of attachment 231629 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231629&action=review
> [...]
> The comments were outdated indeed. Have a look at them once more before committing, because I rewrote them.

I think the new comments are fine

> LayoutTests/ChangeLog:30
> +        * platform/gtk/accessibility/caret-offsets.html: Added.
> +        * platform/gtk/accessibility/caret-offsets-expected.txt: Added.

You forgot to mention the new test caret-offsets-and-extraneous-white-spaces.html here. But that's the only thing I see in this patch at the moment so iy fyou could update this changelog and submit a new patch just with that change, I'll r+ and cq+ rightaway.

By the way, thanks a lot for splitting the original test in two anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.