[Webkit-unassigned] [Bug 133394] fix arm64 css jit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 29 17:20:21 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=133394


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #232273|review?                     |review+
               Flag|                            |




--- Comment #2 from Benjamin Poulain <benjamin at webkit.org>  2014-05-29 17:20:45 PST ---
(From update of attachment 232273)
View in context: https://bugs.webkit.org/attachment.cgi?id=232273&action=review

> Source/WebCore/cssjit/SelectorCompiler.cpp:904
> +    RELEASE_ASSERT(minimumRegisterCountForAttributes <= registerCount);

Please make this an assertion instead of a release assert.
In this case, we do not risk a security problem if the assert is false. RegisterAllocator ensure we crash if we ever overallocate.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list