[Webkit-unassigned] [Bug 133298] Add mock DTMFSender support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 29 13:54:57 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=133298





--- Comment #3 from Eric Carlson <eric.carlson at apple.com>  2014-05-29 13:55:18 PST ---
(From update of attachment 232235)
View in context: https://bugs.webkit.org/attachment.cgi?id=232235&action=review

>> Source/WebCore/platform/mock/RTCDTMFSenderHandlerMock.cpp:61
>> +}
> 
> Two problems: this should be asynchronous, and it should process each character in tones.

Actually you don't need to make this asynchronous because RTCDTMFSender::didPlayTone will post each RTCDTMFToneChangeEvent asynchronously, but you should call m_client->didPlayTone() for each character in "tones". See http://dev.w3.org/2011/webrtc/editor/webrtc.html#methods-4.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list