[Webkit-unassigned] [Bug 122303] Add a verbose flag to binding tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122303





--- Comment #8 from Peter Gal <galpeter at inf.u-szeged.hu>  2014-05-29 09:02:15 PST ---
(From update of attachment 232246)
View in context: https://bugs.webkit.org/attachment.cgi?id=232246&action=review

> Tools/Scripts/run-bindings-tests:47
> +    if "--no-verbose" in argv:
> +        verbose = False
> +    else:
> +        verbose = True

We should make this a bit simpler a one-liner, like in the line 42. Eg.: verbose = not "--no-verbose" in argv

> Tools/Scripts/run-bindings-tests:52
> +        'GObject',

I don't see any point of this change, why is this needed?

> Tools/Scripts/webkitpy/bindings/main.py:117
>              else:
> -                print 'PASS: (%s) %s' % (generator, output_file)
> +                if self.verbose:

Looking at this know I realize we can merge the 'else' and 'if self.verbose' into an 'elsif self.verbose' :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.