[Webkit-unassigned] [Bug 132269] Document.contentType implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 29 06:38:06 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=132269


Csaba Osztrogon√°c <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #232245|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #15 from Csaba Osztrogon√°c <ossy at webkit.org>  2014-05-29 06:38:20 PST ---
(From update of attachment 232245)
View in context: https://bugs.webkit.org/attachment.cgi?id=232245&action=review

> LayoutTests/fast/dom/document-contentType-data-uri.html:10
> +<iframe data-mt="text/xml"></iframe>
> +<iframe data-mt="application/xml"></iframe>
> +<iframe data-mt="image/svg+xml"></iframe>
> +<iframe data-mt="text/html"></iframe>

Changing the order of iframes isn't the proper fix here.

If text/html is the first iframe, its event still fires
at the end. It seems it isn't guaranteed that the events
fire in order. I don't know if it is normal or a bug.

Assuming that it isn't a bug, we should order the PASS messages once 
we caught all of the events in order to have deterministic test.

> LayoutTests/fast/dom/document-contentType-data-uri.html:27
> +var eventMethod = window.addEventListener ? "addEventListener" : "attachEvent";
> +var eventer = window[eventMethod];
> +var messageEvent = eventMethod == "attachEvent" ? "onmessage" : "message";
> +
> +eventer(messageEvent,function(e) {
> +    if (e.data) {
> +        shouldBe('"' + e.data.obtained + '"', '"' + e.data.expected + '"');
> +    } else
> +        testFailed("Null message payload");
> +
> +    if (--expectedMessagesCount == 0)
> +        finishJSTest();
> +},false);

What was the reason to refactor this part of the original patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list