[Webkit-unassigned] [Bug 133028] Build break of 2.4.1 under mingw32/msys

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133028





--- Comment #20 from Milan Crha <mcrha at redhat.com>  2014-05-29 00:26:18 PST ---
(In reply to comment #19)
> I actually think you should replace OS(WINDOWS) in BinarySemaphore.h
> with PLATFORM(WINDOWS), does that work?

I can change the header to use PLATFORM(WIN), yes, but then the semaphore will be a void, while the code seems to be meant to be used on windows and it compiles fine (after fixing the .cpp's file check).

More importantly, how do I test the change? I'm currently only testing whether it compiles, but nothing else, because I do not know how to trigger this code part. According to its name, it looks like a synchronization primitive, which might not be left with an "empty" implementation, otherwise other things would break badly, no? I do not know the webkitgtk code at all, though I still think it would be better to compile the implementation than to skip it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.