[Webkit-unassigned] [Bug 133028] Build break of 2.4.1 under mingw32/msys

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133028





--- Comment #17 from Alberto Garcia <berto at igalia.com>  2014-05-27 14:30:42 PST ---
(In reply to comment #16)
> > Well, or !COMPILER(MSVC) directly, since MSVC already implies Windows.
>
> Yup, that compiles the asm in mingw32 too. (I've just tested it.)

Great, I'll upload the updated patch, but I have one last question:

--- a/Source/WTF/wtf/threads/BinarySemaphore.cpp
+++ b/Source/WTF/wtf/threads/BinarySemaphore.cpp
@@ -26,7 +26,7 @@
 #include "config.h"
 #include "BinarySemaphore.h"

-#if !PLATFORM(WIN)
+#if !OS(WINDOWS)


I understand that in your case you have OS(WINDOWS) but PLATFORM(GTK),
so with this change you would not be compiling BinarySemaphore.cpp, so
where's the implementation of BinarySemaphore that you are using?

BinarySemaphoreWin.cpp is not in any makefile. What's the exact error
message that you are having?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.