[Webkit-unassigned] [Bug 132855] [MediaStream] [EFL] getUserMedia throws DomException always

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132855





--- Comment #9 from Eric Carlson <eric.carlson at apple.com>  2014-05-27 07:57:30 PST ---
(From update of attachment 232069)
View in context: https://bugs.webkit.org/attachment.cgi?id=232069&action=review

> Source/WebKit2/WebProcess/MediaStream/UserMediaPermissionRequestManager.h:42
> +    static PassRefPtr<UserMediaPermissionRequestManager> create(WebPage*);

It doesn't look like "WebPage" can ever be NULL so this and the constructor should take a reference.

> Source/WebKit2/WebProcess/MediaStream/UserMediaPermissionRequestManager.h:43
> +    void requestPermission(UserMediaPermission*);

Can "UserMediaPermission" be NULL? If not, this should take a reference.

> Source/WebKit2/WebProcess/WebCoreSupport/WebUserMediaClient.cpp:60
> +void WebUserMediaClient::requestPermission(WTF::PassRefPtr<UserMediaRequest> request)
> +{
> +    m_userMediaRequest = request;
> +
> +    m_page->userMediaPermissionRequestManager()->requestPermission(this);
> +}

How can the request be stored in m_userMediaRequest? If this is called again before decidePermission() is called, won't decidePermission() make a callback on the wrong request?

> Source/WebKit2/WebProcess/WebCoreSupport/WebUserMediaClient.cpp:65
> +void WebUserMediaClient::cancelRequest(UserMediaRequest*)
> +{
> +    return;
> +}

How does this work? What happens when decidePermission is called subsequently?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.