[Webkit-unassigned] [Bug 132952] [MediaStream] RTCDtmfSender default values need to be updated.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 27 00:28:56 PDT 2014


--- Comment #17 from Kiran <kiran.guduru at samsung.com>  2014-05-27 00:29:19 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > Hi,
> > The code without this patch is also not giving the expected data,
> > The reason for this is 
> > 1. There is not actual implementation for DTMFSender.
> > 2. Mock implementation is, by default, returning null.
> > 
> > So, until the code is added for DTMFHandler (either mock implementation or full implementation), we can not invoke insertDTMF and can not test this feature.
> > 
> > I would like to add a FIXME comment in the code, if reviewer is ok for adding it instead of checking for the expected_output_file.
> Why don't you open a bug about adding mock DTMFSender support and add a FIXME that references that bug. Ideally that would have been done with this patch, but that is my fault for not noticing :-)

I raised a new bug for implementing RTCDTMFSenderHandlerMock (BUG: 133298).
Since this patch is already landed (comment 11), it seems we can close this bug and track this on 133298.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list