[Webkit-unassigned] [Bug 133028] Build break of 2.4.1 under mingw32/msys

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 26 08:18:46 PDT 2014


--- Comment #14 from Alberto Garcia <berto at igalia.com>  2014-05-26 08:19:09 PST ---
(In reply to comment #12)
> That one compiles too, when using gcc.

> -#if !OS(WINDOWS) && (CPU(X86) || CPU(X86_64))
> +#if COMPILER(GCC) && (CPU(X86) || CPU(X86_64))
>      unsigned char result;

I don't think that's good since there are more compilers that support
that syntax (e.g. clang).

I think something like !(OS(WINDOWS) && COMPILER(MSVC)) is probably
better, can you test it?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list