[Webkit-unassigned] [Bug 133157] [GTK] Allow to run the tests on the native X display (instead of running them inside of Xvfb)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133157





--- Comment #6 from Carlos Alberto Lopez Perez <clopez at igalia.com>  2014-05-26 06:41:43 PST ---
(In reply to comment #4)
> (From update of attachment 231957 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231957&action=review
> 
> >>> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:131
> >>> +            help="Don't check the system dependencies (themes, fonts, ...)"),
> >> 
> >> Is this really necessary?
> > 
> > Not strictly necessary, but is consistent with the script for running the layout tests run-webkit-tests:
> > 
> > $ Tools/Scripts/run-webkit-tests --help|grep sys
> >     --nocheck-sys-deps  Don't check the system dependencies (themes)
> > 
> > I can drop it, if you think is better.
> 
> Unless it is necessary, let's drop this.
> It is trivial to add later if needed.

Thanks for your review :)

I have re-uploaded the patch without the "--nocheck-sys-deps" option

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.