[Webkit-unassigned] [Bug 133236] [GStreamer] Add missing <cmath> include

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133236





--- Comment #11 from Adrian Perez <aperez at igalia.com>  2014-05-26 03:00:33 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #4)
> > > (From update of attachment 231990 [details] [details] [details])
> > > It might be better to use wtf/MathExtras.h here.
> > 
> > Well MathExtras.h unconditionally includes cmath and we don't use any of its functions. So not sure it's really worth
> 
> If I recall correctly, it takes care of standardizing cmath across different platforms.

I have checked this, it just includes <cmath> unconditionally, and for
modf/modff it does not have any platform-dependant fixes. Anyway, I think
it is better to include <MathExtras.h>, to avoid issues later on if
GStreamerUtilitiers.cpp starts using functions for which there are fixes
(and avoid subtle bugs).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.