[Webkit-unassigned] [Bug 132814] [Stable] [GTK] GdiObject.h missing in WebKitGTK 2.4.1 tarball

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 26 00:51:00 PDT 2014


--- Comment #13 from Milan Crha <mcrha at redhat.com>  2014-05-26 00:51:23 PST ---
(In reply to comment #10)
> 1) I renamed GdiObject.h to GDIObject.h in the patch. That's the
>    correct name of the file.

Ahh, unnoticed by me, due to Windows being case insensitive in file names. I suppose, for a sake of consistency, the #include directives around the source code should be also changed to capitals on GDI.

> 2) I removed the if TARGET_WIN32 part around it, this is a header file
>    so it's not really necessary.

Are you sure? You definitely do not want to compile windows-specific headers on Linux (or basically any other than Windows system), the same as you do not compile posix related code on windows. I would keep there the check for TARGET_WIN32, the same as it is in Source/WebCore/GNUmakefile.list.am.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list