[Webkit-unassigned] [Bug 132855] [MediaStream] [EFL] getUserMedia throws DomException always

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132855





--- Comment #5 from Praveen Jadhav <praveen.j at samsung.com>  2014-05-25 22:46:41 PST ---
(In reply to comment #3)
> (From update of attachment 231956 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231956&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKPage.cpp:1487
> > +                return true;
> 
> This indentation isn't needed.
> 
> > Source/WebKit2/UIProcess/API/C/WKPageUIClient.h:195
> > +    WKPageDecidePolicyForUserMediaPermissionRequestCallback    decidePolicyForUserMediaPermissionRequest;
> 
> I don't know why the other field names in this struct are aligned, but the new one should probably be aligned too.
> 
> > Source/WebKit2/UIProcess/API/C/WKPageUIClient.h:247
> > +    WKPageDecidePolicyForUserMediaPermissionRequestCallback    decidePolicyForUserMediaPermissionRequest;
> 
> Ditto.
> 
> > Source/WebKit2/UIProcess/API/C/WKPageUIClient.h:366
> > +    WKPageDecidePolicyForUserMediaPermissionRequestCallback    decidePolicyForUserMediaPermissionRequest;
> 
> Ditto.
> 
> > Source/WebKit2/UIProcess/MediaStream/UserMediaPermissionRequestManagerProxy.h:53
> > +    typedef HashMap<uint64_t, RefPtr<UserMediaPermissionRequest> > PendingRequestMap;
> 
> Nit: the space in "> >" is unnecessary.
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/WebUserMediaClient.cpp:69
> > +    // TODO: Create audio and video stream sources here.
> 
> Why would you automatically create audio and video sources here when you don't know what the page wants yet?
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/WebUserMediaClient.cpp:78
> > +        startUserMedia();
> 
> Is this necessary?

startUserMedia() will be called whenever webkitGetUserMedia/getUserMedia API call is triggered from web content. so, I assume this is the proper location to create MediaStreamSource instances. In any case, I will clean up now and leave to next implementation review about initialization location.

> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2810
> > +        return m_userMediaPermissionRequestManager.get();
> 
> Why the indentation?
> 
> > Tools/ChangeLog:3
> > +        [MediaStream] [EFL] getUserMedia throws DomException always..
> 
> Nit: you have two periods here.

Thanks! I will update all the comments in the next patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.