[Webkit-unassigned] [Bug 132814] [Stable] [GTK] GdiObject.h missing in WebKitGTK 2.4.1 tarball

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 25 04:22:38 PDT 2014


Alberto Garcia <berto at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #231626|0                           |1
        is obsolete|                            |
 Attachment #231626|review?                     |
               Flag|                            |
 Attachment #232033|                            |review?
               Flag|                            |

--- Comment #10 from Alberto Garcia <berto at igalia.com>  2014-05-25 04:22:59 PST ---
Created an attachment (id=232033)
 --> (https://bugs.webkit.org/attachment.cgi?id=232033&action=review)

(In reply to comment #9)
> In any case, I propose to not use my rename in the GdiObject.h, just
> feel free to use the other parts of the patch.

Here's the updated patch. I made a couple of changes:

1) I renamed GdiObject.h to GDIObject.h in the patch. That's the
   correct name of the file.

2) I removed the if TARGET_WIN32 part around it, this is a header file
   so it's not really necessary.

We should also check if the master branch is affected by this, although
that would require a separate patch if it was the case.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list