[Webkit-unassigned] [Bug 133028] Build break of 2.4.1 under mingw32/msys

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133028





--- Comment #12 from Milan Crha <mcrha at redhat.com>  2014-05-24 14:13:42 PST ---
(In reply to comment #11)
> (In reply to comment #9)
> > a) Source/WTF/wtf/Atomics.h - do not use MSVC code for mingw32
> 
> Did you try using the non-Windows asm code instead? (the one
> immediately on top)

That one compiles too, when using gcc. I cannot tell how with the runtime, because I do not know what to do to trigger this particular code part, but gcc itself is happy with it. My change in the Atomics.h was (on top of the previous patch):

--- webkitgtk-2.4.1.old/Source/WTF/wtf/Atomics.h    2014-05-18 16:44:51 +0000
+++ webkitgtk-2.4.1/Source/WTF/wtf/Atomics.h    2014-05-24 12:31:40 +0000
@@ -260,7 +260,7 @@ inline void memoryBarrierBeforeUnlock()
 inline bool weakCompareAndSwap(uint8_t* location, uint8_t expected, uint8_t newValue)
 {
 #if ENABLE(COMPARE_AND_SWAP)
-#if !OS(WINDOWS) && (CPU(X86) || CPU(X86_64))
+#if COMPILER(GCC) && (CPU(X86) || CPU(X86_64))
     unsigned char result;
     asm volatile(
         "lock; cmpxchgb %3, %2\n\t"
@@ -270,7 +270,7 @@ inline bool weakCompareAndSwap(uint8_t*
         : "memory"
         );
     return result;
-#elif OS(WINDOWS) && CPU(X86) && !defined(__MINGW32__)
+#elif OS(WINDOWS) && CPU(X86)
     // FIXME: We need a 64-bit ASM implementation, but this cannot be inline due to
     // Microsoft's decision to exclude it from the compiler.
     bool result = false;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.