[Webkit-unassigned] [Bug 133156] make css jit work on arm64

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 23 17:48:38 PDT 2014


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #231989|review?                     |review+
               Flag|                            |

--- Comment #16 from Benjamin Poulain <benjamin at webkit.org>  2014-05-23 17:49:01 PST ---
(From update of attachment 231989)
View in context: https://bugs.webkit.org/attachment.cgi?id=231989&action=review

> Source/WebCore/cssjit/RegisterAllocator.h:125
> +        return Vector<JSC::MacroAssembler::RegisterID, calleeSavedRegisterCount>(m_reservedCalleeSavedRegisters);

Do you need to explicit copy constructor here?

> Source/WebCore/cssjit/StackAllocator.h:76
> +        stackReferences.reserveCapacity(registerCount);


> Source/WebCore/cssjit/StackAllocator.h:113
> +        ASSERT(m_offsetFromTop >= stackUnitInBytes * registerCount);

Is this right on ARM64? You could have 2 registers by stack units.

This is probably only good for x86_64.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list