[Webkit-unassigned] [Bug 133157] [GTK] Allow to run the tests on the native X display (instead of running them inside of Xvfb)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 23 11:58:43 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=133157





--- Comment #3 from Carlos Alberto Lopez Perez <clopez at igalia.com>  2014-05-23 11:59:04 PST ---
(In reply to comment #2)
> (From update of attachment 231957 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231957&action=review
> 
> Quick questions
> 
> > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:131
> > +            optparse.make_option("--nocheck-sys-deps", action="store_true", default=False,
> > +            help="Don't check the system dependencies (themes, fonts, ...)"),
> 
> Is this really necessary?
> 
Not strictly necessary, but is consistent with the script for running the layout tests run-webkit-tests:

$ Tools/Scripts/run-webkit-tests --help|grep sys
    --nocheck-sys-deps  Don't check the system dependencies (themes)

I can drop it, if you think is better.

> > Tools/Scripts/webkitpy/port/driver.py:493
> > +    def check_driver(port):
> 
> Where is it used?

Is used on the drivers Xvfb, Weston and this new one (xorgdriver):

Tools/Scripts/webkitpy/port/xvfbdriver.py
Tools/Scripts/webkitpy/port/westondriver.py

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list