[Webkit-unassigned] [Bug 133156] make css jit work on arm64

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 23 11:08:59 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=133156





--- Comment #12 from Benjamin Poulain <benjamin at webkit.org>  2014-05-23 11:09:21 PST ---
(In reply to comment #10)
> > Did you try debug builds?
> Yes.  It works fine.  I think this should be changed to make debugging debug builds easier.
> > > Source/WebCore/cssjit/StackAllocator.h:82
> > > +            stackReferences.append(StackReference(m_offsetFromTop - stackUnitInBytes / 2));
> > > +            stackReferences.append(StackReference(m_offsetFromTop));
> > 
> > Is this right?
> Yes.  The order is arbitrary, but it has to be consistent.  This way the registers are pushed in the order they are in the vector and popped in the opposite order of the given vector, which I think makes the most sense and is most like x86_64.

The order in which you store registers on the stack can be arbitrary. But the StackReferences are used to access values by address, they need to match the order in which the register are stored on the stack.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list