[Webkit-unassigned] [Bug 133156] make css jit work on arm64

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 23 10:41:58 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=133156





--- Comment #10 from Alex Christensen <achristensen at apple.com>  2014-05-23 10:42:22 PST ---
(In reply to comment #8)
> > Source/WebCore/cssjit/SelectorCompiler.cpp:550
> > -#if CSS_SELECTOR_JIT_DEBUGGING && ASSERT_DISABLED
> > +#if CSS_SELECTOR_JIT_DEBUGGING
> 
> IIRC, this was for certain debug builds, I can't remember why, that was during the initial proof-of-concept work.
> 
> Did you try debug builds?
Yes.  It works fine.  I think this should be changed to make debugging debug builds easier.
> > Source/WebCore/cssjit/StackAllocator.h:82
> > +            stackReferences.append(StackReference(m_offsetFromTop - stackUnitInBytes / 2));
> > +            stackReferences.append(StackReference(m_offsetFromTop));
> 
> Is this right?
Yes.  The order is arbitrary, but it has to be consistent.  This way the registers are pushed in the order they are in the vector and popped in the opposite order of the given vector, which I think makes the most sense and is most like x86_64.

I fixed all other comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list