[Webkit-unassigned] [Bug 132951] CSS JIT: Apply backtracking optimization to adjacent backtracking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132951


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231904|review?                     |review+
               Flag|                            |




--- Comment #8 from Benjamin Poulain <benjamin at webkit.org>  2014-05-23 01:17:04 PST ---
(From update of attachment 231904)
View in context: https://bugs.webkit.org/attachment.cgi?id=231904&action=review

That's awwweeesssooooome.

Great work.
The bots are sick. You don't need to update the patch, I'll land it manually tomorrow.

> LayoutTests/fast/selectors/backtracking-adjacent-optimized.html:23
> +        <a class="ok"></a>  <!-- Mathced. -->

Typo here: Mathced.

> LayoutTests/fast/selectors/backtracking-adjacent-optimized.html:24
> +        <a class="ng"></a>  <!-- Failed. And backtrack from here. -->

I would duplicate this a dozen of times. That we we can to find bugs in which we would exhaust the register allocator.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.