[Webkit-unassigned] [Bug 133171] [WebKit2-EFL] Fix EWK2BackForwardListTest test fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133171





--- Comment #2 from Grzegorz Czajkowski <g.czajkowski at samsung.com>  2014-05-22 00:11:00 PST ---
(From update of attachment 231861)
View in context: https://bugs.webkit.org/attachment.cgi?id=231861&action=review

Thanks for fixing it. The patch itself looks good to me. Please consider adding some details to ChangeLog.

> Source/WebKit2/ChangeLog:3
> +        [WebKit2-EFL] Fix EWK2BackForwardListTest test fails

Nit: generally we use [EFL][WK2] prefix.

> Source/WebKit2/ChangeLog:8
> +        Use local test html pages instead of EWK2UnitTestServer for ewk2_back_forward_list tests.

Could you mention in ChangeLog why this change is needed (why can not EWK2UnitTestServer load the page properly)? I believe that, this note will encourage reviewers to have a look at the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.