[Webkit-unassigned] [Bug 131094] Remove one of the CSSProperty constructor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 21 09:42:16 PDT 2014


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #231687|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #10 from Darin Adler <darin at apple.com>  2014-05-21 09:42:38 PST ---
(From update of attachment 231687)
View in context: https://bugs.webkit.org/attachment.cgi?id=231687&action=review

> Source/WebCore/css/StyleProperties.h:70
> +        bool isSetFromShorthand() const { return propertyMetadata().m_isSetFromShorthand; }
> +        int indexInShorthandsVector() const { return propertyMetadata().m_indexInShorthandsVector; }

Please don’t add these new public member functions. We don’t need the functions at all, since they are only used in one place and that’s inside this class. And if you really felt compelled to add the functions, they should be private since they are only used by a member function.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list