[Webkit-unassigned] [Bug 133028] Build break of 2.4.1 under mingw32/msys

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133028





--- Comment #11 from Alberto Garcia <berto at igalia.com>  2014-05-21 06:02:46 PST ---
(In reply to comment #9)
> a) Source/WTF/wtf/Atomics.h - do not use MSVC code for mingw32

Did you try using the non-Windows asm code instead? (the one
immediately on top)

> f) Source/WebCore/rendering/RenderBlock.cpp - the check for
> structure size fails on mingw32/msys, the enum size or the split of
> bit fields make the structure larger than with a 32bit uint, thus I
> both moved the bit fields to be in one group, and then added enum
> into the "control" structure

> --- webkitgtk-2.4.1.old/Source/WebCore/rendering/RenderBlock.h	2014-05-16 19:07:53 +0000
> +++ webkitgtk-2.4.1/Source/WebCore/rendering/RenderBlock.h	2014-05-17 07:38:01 +0000
> @@ -613,8 +613,8 @@ public:
>      unsigned m_beingDestroyed : 1;
>      unsigned m_hasMarkupTruncation : 1;
>      unsigned m_hasBorderOrPaddingLogicalWidthChanged : 1;
> -    enum LineLayoutPath { UndeterminedPath, SimpleLinesPath, LineBoxesPath, ForceLineBoxesPath };
>      unsigned m_lineLayoutPath : 2;
> +    enum LineLayoutPath { UndeterminedPath, SimpleLinesPath, LineBoxesPath, ForceLineBoxesPath };

You mean that the way this is declared doesn't allow the compiler to
use one single uint32?

> --- webkitgtk-2.4.1.old/Source/WebCore/rendering/RenderBlock.cpp	2014-05-16 19:07:53 +0000
> +++ webkitgtk-2.4.1/Source/WebCore/rendering/RenderBlock.cpp	2014-05-17 07:38:01 +0000
> @@ -83,6 +83,7 @@ using namespace HTMLNames;
>
>  struct SameSizeAsRenderBlock : public RenderBox {
>      uint32_t bitfields;
> +    enum LineLayoutPath { UndeterminedPath, SimpleLinesPath, LineBoxesPath, ForceLineBoxesPath };
>  };

I don't understand why you need to declare that enum there again, what
happens if you don't do it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.