[Webkit-unassigned] [Bug 132856] [GTK][Stable] Missing implementation of callToJavaScript/callToNativeFunction with msys/mingw32

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 20 23:10:52 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=132856





--- Comment #3 from Milan Crha <mcrha at redhat.com>  2014-05-20 23:11:13 PST ---
(In reply to comment #2)
> (From update of attachment 231674 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231674&action=review
> 
> > webkitgtk-2.4.1/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:494
> > +#if ENABLE(COMPUTED_GOTO_OPCODES)
> >          goto llint_generic_return_point;
> > +#else
> > +	// TODO: do something sane here
> > +#endif
> 
> Why does this need to be conditional on ENABLE(COMPUTED_GOTO_OPCODES)?

I thought that there is a reason why the label is used and it is defined only when the ENABLE(COMPUTED_GOTO_OPCODES) is defined as well. If there can be used a code in "TODO" always, then even better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list