[Webkit-unassigned] [Bug 132122] [CSS Grid Layout] Implementation of the "grid" shorthand.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132122





--- Comment #10 from Benjamin Poulain <benjamin at webkit.org>  2014-05-19 14:22:48 PST ---
(From update of attachment 230607)
View in context: https://bugs.webkit.org/attachment.cgi?id=230607&action=review

Quick comments.

> Source/WebCore/css/CSSParser.cpp:4942
> +    RefPtr<CSSValue> autoColumnsValue = nullptr;
> +    RefPtr<CSSValue> autoRowsValue = nullptr;

No need for = nullptr. RefPtr is initialized like that.

> LayoutTests/fast/css-grid-layout/grid-shorthand-get-set.html:36
> +/* Bad values. */
> +
> +#gridWithExplicitAndImplicit {
> +    -webkit-grid: 10px / 20px column;
> +}
> +#gridWithMisplacedNone1 {
> +    -webkit-grid: column 10px / none 20px;
> +}
> +#gridWithMisplacedNone2 {
> +    -webkit-grid: 10px / 20px none;
> +}

That's very little coverage for bad cases.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.