[Webkit-unassigned] [Bug 127938] Web Inspector: Inspect Element sometimes does not select the right DOM Node

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127938


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231718|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #13 from Joseph Pecoraro <joepeck at webkit.org>  2014-05-19 13:41:42 PST ---
(From update of attachment 231718)
View in context: https://bugs.webkit.org/attachment.cgi?id=231718&action=review

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:275
> +        this._restoreSelectedNodeIsAllowed = true;
>          var node = this._idToDOMNode[nodeId];

Style: lets put an empty newline after setting the state.

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:285
> +        this._restoreSelectedNodeIsAllowed = false;

Style: lets put an empty newline after setting the state.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:297
> +        if (!WebInspector.domTreeManager.restoreSelectedNodeIsAllowed)
> +            return;

The same check should be done in selectLastSelectedNode below, which is what can be called async, and we don't want to restore the selected node in the async case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.