[Webkit-unassigned] [Bug 132988] Link search area for touch events is too large in some cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 16 13:13:39 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
 Attachment #231585|review?                     |review+
               Flag|                            |

--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-05-16 13:14:01 PST ---
(From update of attachment 231585)
View in context: https://bugs.webkit.org/attachment.cgi?id=231585&action=review

> Source/WebCore/page/ios/FrameIOS.mm:435
> +    float scale = page() ? page()->pageScaleFactor() : 1;

I don't know how we'd ever get here with a null page.

> Source/WebCore/page/ios/FrameIOS.mm:-469
> -        // We don't approximate the node if we are dragging, we instead force the user to be precise.

Did the code related to this comment disappear some time in the past?

> Source/WebCore/platform/ios/PlatformScreenIOS.mm:102
> +float mainScreenRelativePPI()

This name still confuses me. It sounds more like a screenPPIFactor(), and a comment in the header should say what it's relative to.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list