[Webkit-unassigned] [Bug 132907] [EFL] Add include path of cxxabi.h if FTL JIT is enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132907





--- Comment #7 from Raphael Kubo da Costa (:rakuco) <rakuco at webkit.org>  2014-05-16 13:01:17 PST ---
(From update of attachment 231452)
View in context: https://bugs.webkit.org/attachment.cgi?id=231452&action=review

If you just need to look for a header file, it is better to just do that directly in OptionsEfl.cmake. Otherwise, you need to write a proper find file with a license and which handles its arguments and sets the _FOUND variable correctly.

>> Source/cmake/FindLIBCXXABI.cmake:8
>> +    HINTS "/usr/include/libcxxabi/"
> 
> Doesn't libcxxabi have .pc file ? Other FindFoo.cmake files have used ${PC_FOO_INCLUDEDIR}.
> 
> Additionally, how to install libcxxabi library ? Should we install it manually ?

This HINTS line is wrong. /usr/include is a path looked at by default in most Unix variants. You should probably use PATH_SUFFIXES instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.