[Webkit-unassigned] [Bug 130638] [Win64] ASM LLINT is not enabled.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 16 10:33:50 PDT 2014


--- Comment #36 from peavo at outlook.com  2014-05-16 10:34:11 PST ---
(In reply to comment #35)
> View in context: https://bugs.webkit.org/attachment.cgi?id=231527&action=review
> > Source/JavaScriptCore/JavaScriptCore.vcxproj/jsc/jscCommon.props:19
> > +      <StackReserveSize>2097152</StackReserveSize>
> Won't increasing the stack reserve size also need to be done in WinLauncher, DumpRenderTree, and any other executable that uses JavaScriptCore?  jsc.exe is the only executable used to run the function-apply-many-args test, but the stack overflow problem will exist in any executable using JavaScriptCore if it runs code similar to the test.

Good point, we could do that, but I'm not sure it's required, as I assume it's OK for different platforms/executables to have different stack limits.
A script allocating past the stack limit will get a JS exception, and not a crash, I believe, which can be handled by the script.
Please correct me if I'm wrong :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list