[Webkit-unassigned] [Bug 127938] Web Inspector: Inspect Element sometimes does not select the right DOM Node

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127938


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231542|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from Timothy Hatcher <timothy at apple.com>  2014-05-16 09:37:38 PST ---
(From update of attachment 231542)
View in context: https://bugs.webkit.org/attachment.cgi?id=231542&action=review

Looks good. Only a minor issue.

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:44
> +    this._restoreAllowed = true;

_restoreSelectedNodeAllowed?

> Source/WebInspectorUI/UserInterface/Views/FrameDOMTreeContentView.js:74
> +        if (WebInspector.domTreeManager._restoreAllowed)

This should not access a private property of another class. _restoreSelectedNodeAllowed should be exposed as a public getter or as isRestoreSelectedNodeAllowed().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.