[Webkit-unassigned] [Bug 132939] [WebKit2-EFL] Fix safety check failed errors in API tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 15 17:35:10 PDT 2014


--- Comment #3 from Ryuan Choi <ryuan.choi at samsung.com>  2014-05-15 17:35:32 PST ---
(From update of attachment 231498)
View in context: https://bugs.webkit.org/attachment.cgi?id=231498&action=review

> Source/WebKit2/ChangeLog:9
> +        ewk_view_contents_size_get unit test has tested unsupported evas object type. But ewk APIs gives critical error, when given evas object
> +        is not ewk type. So, we can't test wrong evas object type by using current test. so Removing the test line.

I am not sure what is the problem. It is intentionally tested.

>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:-1146
>> -    ewk_view_contents_size_get(0, &contentsWidth, &contentsHeight);
> I think this is to check if width and height can be initialized with 0 when Evas_Object is null. To be honest, I don't know why we have to initialize width/height when evas object is null.
> Eina_Bool ewk_view_contents_size_get(const Evas_Object* ewkView, Evas_Coord* width, Evas_Coord* height)
> {
>     EwkView* impl = toEwkViewChecked(ewkView);
>     if (EINA_UNLIKELY(!impl)) {
>         EINA_LOG_CRIT("no private data for object %p", ewkView);
>         if (width)
>             *width = 0;
>         if (height)
>             *height = 0;
>         return false;
>     }
> If we remove this test logic, I think we have to remove the initialization code together.

Maybe, I don't have objection about removing the logic that clears the value.
But I still want test case although we remove this logic.

This test case explains the behavior of ewebkit well when wrong ewkView is given.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list