[Webkit-unassigned] [Bug 132952] [MediaStream] RTCDtmfSender default values need to be updated.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132952


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #231519|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #6 from Eric Carlson <eric.carlson at apple.com>  2014-05-15 10:45:13 PST ---
(From update of attachment 231519)
View in context: https://bugs.webkit.org/attachment.cgi?id=231519&action=review

> LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html:61
> +                    dtmfsender.insertDTMF("1", "40", "30");
> +                    shouldBeEqualToString('dtmfsender.toneBuffer', "1");
> +                    shouldBeEqualToString('dtmfsender.duration', "40");
> +                    shouldBeEqualToString('dtmfsender.interToneGap', "30");
> +
> +                    dtmfsender.insertDTMF("1", "6000");
> +                    shouldBeEqualToString('dtmfsender.toneBuffer', "1");
> +                    shouldBeEqualToString('dtmfsender.duration', "6000");
> +                    shouldBeEqualToString('dtmfsender.interToneGap', "70");
> +

You should also test to ensure that exceptions are thrown when the limits are exceeded. Something like this should work:

            testDOMException("dtmfsender.insertDTMF('1', '20', '30')", "DOMException.SYNTAX_ERR");
            testDOMException("dtmfsender.insertDTMF('1', '7000', '30')", "DOMException.SYNTAX_ERR");

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.