[Webkit-unassigned] [Bug 131483] [EFL][WK2] Implement web notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131483





--- Comment #10 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2014-05-14 22:37:38 PST ---
(From update of attachment 231491)
View in context: https://bugs.webkit.org/attachment.cgi?id=231491&action=review

> Source/WebKit2/PlatformEfl.cmake:380
> +    "${CMAKE_CURRENT_SOURCE_DIR}/UIProcess/API/efl/ewk_notification.h"

It would be good if you open this new API files when you finish the implementation.

> Source/WebKit2/UIProcess/API/efl/EWebKit2.h:48
> +#include "ewk_notification.h"

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:78
> +    , m_notificationProvider(std::make_unique<NotificationProviderEfl>(context))

Can I ask why you need to have ownership of m_notificationProvider ? If this is only for passing an pointer to WebCore side, I think we don't need to have this member variable and ownership.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.